Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing Headers - Linker Errors #300

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

Fix: Missing Headers - Linker Errors #300

wants to merge 16 commits into from

Conversation

dangell7
Copy link
Collaborator

@dangell7 dangell7 commented Mar 18, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@RichardAH
Copy link
Contributor

Some of the changes here remove JSON dumps from important logging lines. Can you rework it so those dumps remain?

@dangell7 dangell7 changed the title Fix: Missing Headers - Linker Errors Fix: Missing Headers - Linker Errors [DO NOT MERGE] Mar 25, 2024
@dangell7 dangell7 changed the title Fix: Missing Headers - Linker Errors [DO NOT MERGE] Fix: Missing Headers - Linker Errors May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants